Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak in dropdown action #197769

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: memory leak in dropdown action #197769

merged 2 commits into from
Nov 9, 2023

Conversation

SimonSiefke
Copy link
Contributor

Fixes #197767

Output with --measure event-listener-count

{
  "eventListenerCount": {
    "before": 1761,
    "after": 1761
  },
  "isLeak": false
}

@bpasero bpasero assigned bpasero and unassigned rebornix Nov 9, 2023
@bpasero bpasero added this to the November 2023 milestone Nov 9, 2023
@bpasero bpasero merged commit 9dfcad9 into microsoft:main Nov 9, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Memory leak in dropdownAction
5 participants
@SimonSiefke @bpasero @TylerLeonhardt @rebornix @VSCodeTriageBot