Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aux window - allow to drag tabs/groups out to open in windows #197809

Merged
merged 18 commits into from Nov 10, 2023
Merged

Aux window - allow to drag tabs/groups out to open in windows #197809

merged 18 commits into from Nov 10, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Nov 9, 2023 •
edited

For #8171

@bpasero
wip
739026a 
Things that are nice:
- we can detect if a drop occurs over another window or not

Things that are ugly:
- drop feedback is delayed due to async calls
- standard drop still occurs (e.g. file created on desktop)

Things that are missing:
- support for single tabs
@bpasero
Merge branch 'main' into ben/dnd-outside-window-wip
db9ee0c
@bpasero bpasero self-assigned this Nov 9, 2023
@bpasero bpasero added this to the November 2023 milestone Nov 9, 2023
@bpasero bpasero changed the title Ben/dnd-outside-window-wip Aux window - allow to drag tabs/groups out to open in windows Nov 9, 2023
@bpasero bpasero marked this pull request as ready for review November 10, 2023 08:17
@bpasero bpasero enabled auto-merge (squash) November 10, 2023 08:17
@bpasero bpasero merged commit e984f91 into main Nov 10, 2023
6 checks passed
@bpasero bpasero deleted the ben/dnd-outside-window-wip branch November 10, 2023 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benibenj benibenj benibenj approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpasero @benibenj