Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command sequence decorations to dev mode #197857

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 9, 2023

This will help a lot with issues like #197736 and improving shell integration reliability in general.

This new overlay shows the positions of the A, B, C and D shell integration sequences. This currently works on command finished, meaning these are the positions after they have been adjusted.

For example the below shows clear inconsistencies with C (command executed):

image

We can expand on this in the future to show sequence x positions.

This will help a lot with issues like #197736 and improving shell
integration reliability in general.
@Tyriar Tyriar added this to the November 2023 milestone Nov 9, 2023
@Tyriar Tyriar self-assigned this Nov 9, 2023
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@Tyriar Tyriar enabled auto-merge November 9, 2023 20:02
@Tyriar Tyriar merged commit dd076d0 into main Nov 9, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/dev_mode_improvement branch November 9, 2023 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants