Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Acc] Keyboard accessible tooltips- Fixes #132344 #197965

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

r3m0t
Copy link
Contributor

@r3m0t r3m0t commented Nov 10, 2023

Enables the Blink feature keyboard accessible tooltips

Ensures some elements with tabindex=-1 have the title attribute (breadcrumbs and the editor title toolbar), allowing keyboard accessible tooltips

Fixes #132344

I navigate with the keyboard and see tooltips in the breadcrumb and the editor title (Split Editor Right) and the layout toggles (Toggle Panel)

However, when using the mouse, some things have double tooltips like the layout toggles.

Ensures some elements with tabindex=-1 have the title attribute (breadcrumbs and the editor title toolbar), allowing keyboard accessible tooltips
@r3m0t r3m0t changed the title Fixes #132344 [Acc] Keyboard accessible tooltips- Fixes #132344 Nov 10, 2023
@meganrogge meganrogge self-requested a review November 10, 2023 22:06
@meganrogge
Copy link
Contributor

meganrogge commented Nov 10, 2023

Thank you so much for looking into this. I am still not seeing it work - what am I doing wrong here?

Edit: I see you said you've tested this on Windows. I'm seeing different behavior probably because I'm using mac.

Screen.Recording.2023-11-10.at.2.14.16.PM.mov

@r3m0t
Copy link
Contributor Author

r3m0t commented Nov 11, 2023

Well that definitely explains it! Not surprising the Edge team never tested the feature on a Mac. I tried to use a web based gif capture tool but it wasn't able to capture the tooltips.

@meganrogge
Copy link
Contributor

meganrogge commented Nov 13, 2023

This works well on windows for some of the buttons @r3m0t . Thanks for working on it. Is it ready for review or still a wip?

@meganrogge meganrogge marked this pull request as ready for review November 15, 2023 16:59
@meganrogge
Copy link
Contributor

I think we should merge this since it fixes some cases.

@VSCodeTriageBot VSCodeTriageBot added this to the November 2023 milestone Nov 15, 2023
@bpasero bpasero requested review from jrieken and deepak1556 and removed request for bpasero November 15, 2023 18:28
@deepak1556
Copy link
Contributor

I think this should be behind a runtime flag mainly because the changes are incomplete in upstream, refs comment https://bugs.chromium.org/p/chromium/issues/detail?id=829352#c45 . @meganrogge it would be good to know what work is remaining to enable it by default from the edge team.

@meganrogge meganrogge modified the milestones: November 2023, December 2023 Nov 21, 2023
@meganrogge
Copy link
Contributor

@deepak1556 do we have an edge contact?

@meganrogge
Copy link
Contributor

I imagine putting it behind a runtime flag will mean almost no users see the change. Should we instead wait until it's fixed upstream?

Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on enabling the runtime feature flag.

@meganrogge meganrogge merged commit a55ca03 into microsoft:main Nov 27, 2023
6 checks passed
@deepak1556 deepak1556 modified the milestones: December 2023, November 2023 Nov 27, 2023
meganrogge added a commit that referenced this pull request Nov 27, 2023
This reverts commit a55ca03, reversing
changes made to c6eb717.
SimonSiefke pushed a commit to SimonSiefke/vscode that referenced this pull request Nov 27, 2023
Revert "Merge pull request microsoft#197965 from r3m0t/selfish-crawdad"
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Acc] Button tooltip doesn't show up on tab\
4 participants