Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in menubar #198051

Closed
SimonSiefke opened this issue Nov 12, 2023 · 1 comment · Fixed by #198052
Closed

memory leak in menubar #198051

SimonSiefke opened this issue Nov 12, 2023 · 1 comment · Fixed by #198052
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded

Comments

@SimonSiefke
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.84.2
  • OS Version: Ubuntu 23.04

Steps to Reproduce:

  1. Open a VSCode Window
  2. In the menu at the top, click on "File" which opens the menu
  3. In the menu at the top, click on "File" again which closes the menu
  4. A Menu instance has been added, but not been removed

Test Script

git clone git@github.com:SimonSiefke/vscode-memory-leak-finder.git &&
cd vscode-memory-leak-finder &&
git checkout v5.22.2 &&
npm ci &&
node packages/cli/bin/test.js --cwd packages/e2e  --check-leaks --measure instance-counts-with-source-map --only title-bar &&
cat .vscode-memory-leak-finder-results/instance-counts-with-source-map/title-bar-menu-toggle.json

Output

{
  "instanceCounts": {
    "before": [
      {
        "name": "Menu",
        "count": 1
      }
    ],
    "after": [
      {
        "name": "Menu",
        "count": 2
      }
    ]
  },
  "isLeak": true
}
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues labels Dec 19, 2023
@sbatten sbatten added this to the December / January 2024 milestone Dec 19, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 21, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2024
@jrieken jrieken added the verified Verification succeeded label Jan 25, 2024
@jrieken
Copy link
Member

jrieken commented Jan 25, 2024

verified in code review

@SimonSiefke Thank you for these great issues and fixes ❤️

@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants