Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert settings search results ordering #198703

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Nov 20, 2023

Fixes #197773

This PR partially reverts the ordering algorithm of the Settings editor search results so that keyword match results show up first. The table of contents order is still calculated and used in two cases:

  1. When the search query only has filters, such as if the user is filtering down to a feature area with @feature, or an extension area with @ext.
  2. As a last resort for two items that are determined to have the same relevancy.

@rzhao271 rzhao271 self-assigned this Nov 20, 2023
@rzhao271 rzhao271 added this to the November 2023 milestone Nov 20, 2023
@rzhao271 rzhao271 marked this pull request as ready for review November 20, 2023 19:35
@rzhao271 rzhao271 merged commit afbfcca into main Nov 20, 2023
6 checks passed
@rzhao271 rzhao271 deleted the rzhao271/revert-order branch November 20, 2023 20:47
Splizard pushed a commit to Splizard/vscode-mobile that referenced this pull request Nov 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Revert settings search in the Settings editor to order results by keyword matches first
2 participants