Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console format of fetchUrl #198909

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

yiliang114
Copy link
Contributor

I add a builtInExtension config in the product.json, and when I am using start-web, the built-in expansion will automatically download, and the log will be printed at this time because I turned on the log switch.

image

@chrmarti chrmarti assigned bpasero and unassigned chrmarti Nov 24, 2023
@bpasero bpasero added this to the Backlog milestone Nov 24, 2023
@bpasero bpasero modified the milestones: Backlog, December 2023 Dec 4, 2023
aeschli
aeschli previously approved these changes Dec 4, 2023
@bpasero bpasero enabled auto-merge (squash) December 4, 2023 14:32
@bpasero
Copy link
Member

bpasero commented Dec 4, 2023

@yiliang114 can you make sure to run yarn compile in the build folder and check the JS file in.

@bpasero bpasero added the info-needed Issue requires more information from poster label Dec 4, 2023
@yiliang114
Copy link
Contributor Author

@yiliang114 can you make sure to run yarn compile in the build folder and check the JS file in.

Sure, I have run yarn compile in the build folder, but lib/*.js did not change.

bpasero
bpasero previously approved these changes Dec 5, 2023
@bpasero bpasero dismissed stale reviews from aeschli and themself via 20a5f37 December 5, 2023 06:27
@bpasero bpasero merged commit 1ac14a7 into microsoft:main Dec 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants