Fix updating relative number for sticky scroll #199101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks a lot for the PR and the good catch. |
aiday-mar
approved these changes
Nov 27, 2023
aeschli
approved these changes
Nov 27, 2023
No worries. Anything else before merge? |
|
No it's all good, we merged the PR, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where line number is not updated properly when cursor changes and relative line numbers is activated. I.e. the following settings:
The default value of the
rebuildFromLineargument isInfinityfor the_renderStickyScrollfunction, changing it to-1solves the problem and correctly updates relative lines for sticky scroll.