Memory leak in color picker widget

[SimonSiefke]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.84.2
• OS Version: Ubuntu 23.04

Steps to Reproduce:

1. Open a text editor
2. Open the command palette
3. Run the Show or Focus Standalone Color Picker command
4. Once the color picker is visible, press Escape to hide the color picker
5. Notice that two click event listeners have been added, but not been removed:

{
  "eventListeners": [
    {
      "type": "click",
      "description": "o=>{this.f.fire()}",
      "stack": ["listener (vscode-linux-x64-1.84.2/resources/app/out/vs/workbench/workbench.desktop.main.js:716:18657)"],
      "count": 1,
      "originalStack": ["/src/vs/editor/contrib/colorPicker/browser/colorPickerWidget.ts:458:25"],
      "originalName": "e"
    },
    {
      "type": "click",
      "description": "()=>{this.f.fire()}",
      "stack": ["listener (vscode-linux-x64-1.84.2/resources/app/out/vs/workbench/workbench.desktop.main.js:716:13832)"],
      "count": 1,
      "originalStack": ["/src/vs/editor/contrib/colorPicker/browser/colorPickerWidget.ts:120:25"],
      "originalName": null
    }
  ],
  "isLeak": true
}

Automated test script

git clone git@github.com:SimonSiefke/vscode-memory-leak-finder.git &&
cd vscode-memory-leak-finder &&
git checkout v5.29.0 &&
npm ci &&
node packages/cli/bin/test.js --cwd packages/e2e  --check-leaks --measure-after --measure event-listeners --runs 7  --only color-picker &&
cat .vscode-memory-leak-finder-results/event-listeners/editor.color-picker-toggle.json

[aiday-mar]

Good catch, thanks a lot for the PR