aux window: add barrier waiting for styles to load #199882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug toolbar needs to compute its size and positioning, which without this fails if executed in onDidChangeActiveContainer. The result of these changes is a new property on the ILayoutService.
connor4312
force-pushed
the
connor4312/aux-window-css
branch
from
7910cc7
to
684ffcb
Compare
bpasero
added
the
workbench-auxwindow
bpasero
requested changes
Dec 4, 2023
src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
Dec 4, 2023
src/vs/workbench/browser/layout.ts
Outdated
| this._onDidAddContainer.fire({ container: window.container, disposables: eventDisposables }); | ||
|
|
||
| disposables.add(window.onDidLayout(dimension => this.handleContainerDidLayout(window.container, dimension))); | ||
| disposables.add(window.onWillClose(() => this.auxWindowStylesLoaded.delete(window.container))); |
There was a problem hiding this comment.
You can just add a toDisposable here, no need to listen to the close event. The idea is that the passed disposables share the same lifecycle as the window.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug toolbar needs to compute its size and positioning, which without this fails if executed in onDidChangeActiveContainer. The result of these changes is a new property on the ILayoutService.