Checking that the effectiveLineNumber is valid before accessing the line content

[aiday-mar]

Fixes #199938

[aeschli]

The problem is on line 205, where the effectiveLineNumber is increased without checking whether this is possible.

[aiday-mar]

Integration test errors appear to not be related at all to the change, this is quite curious, this needs some investigation

[aiday-mar]

Yesterday during our discussion you mentioned that we could reuse the calculation in the variable lineHasSpace to calculate the effective column number. After some inspection I am not sure this would make the code clearer. The current effective column number is calculated as follows:

!!model.getLineContent(effectiveLineNumber).match(/^\S\s*$/) ? 2 : 1

So the effective column number is:

• 2 is there is only one character at the beginning of the line, and the rest are whitespace
• 1 otherwise

I am not sure how the lineHasSpace calculation would be used here? Initially that column value was 1 before the recent lightbulb work done.

[aeschli]

ok. sure. Buyt still, the check to go on column 2 should only happen if we increased or decreased the effective line number.

[aeschli]

ok. sure. But still, the check and column update should only happen when there was no space on the original line.

[aiday-mar]

Ah yes now I understand, will do 👍🏻

[aiday-mar]

I added the code into the if statement

stale

[alexdima]

LGTM. @justschen Please also take a look.

[justschen]

yes lgtm!