debug: fix error restarting debug session #200203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #196950 Emit more information from the debug service about the type of termination happening, and whether a restart is expected. Keep the session listeners for sessions around if a restart is expected. Additionally: - inline chat decorations did not track restarted sessions - there was a leak where we retained listeners for every launched debug session on the DebugService
TylerLeonhardt
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196950
Emit more information from the debug service about the type of
termination happening, and whether a restart is expected. Keep the
session listeners for sessions around if a restart is expected. Additionally:
cc @roblourens