Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in diff editor #200381

Closed
SimonSiefke opened this issue Dec 8, 2023 · 0 comments · Fixed by #200382
Closed

Memory leak in diff editor #200381

SimonSiefke opened this issue Dec 8, 2023 · 0 comments · Fixed by #200382
Assignees
@hediet
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
December / Januar...

Comments

@SimonSiefke
Copy link
Contributor

SimonSiefke commented Dec 8, 2023 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.85.0
  • OS Version: Ubuntu 23.04

Steps to Reproduce:

  1. Create a file a.txt with contents a
  2. Create a file b.txt with contents b
  3. In the explorer, right click on file a.txt and select Select for compare
  4. In the explorer, right click on file b.txt and select Compare with selected, opening the diff editor
  5. Close the diff editor
  6. Notice that click, mousedown and mouseup event listeners have been added but not been removed
{
  "eventListenersWithStackTrace": [
    {
      "type": "click",
      "description": "r=>{this.g.revertRangeMappings(this.j),r.stopPropagation(),r.preventDefault()}",
      "objectId": "-3511702809039278327.4.12112",
      "stack": [
        "listener (file:///home/simon/.cache/repos/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:735:22894)",
        "new o (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22894)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22233",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:14193)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "m.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:13185)",
        "D.setWidth (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:629:87667)",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:30579)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "p (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11170)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34803)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "D.h (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:23173)",
        "D.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:22981)",
        "a.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34895)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:35107)",
        "y.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2148:10477)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23544",
        "b.W (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23663)",
        "b.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23530)",
        "ee.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:31158)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "c.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:49448)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:59584)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:63999)",
        "T.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:32571)",
        "k.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:33816)",
        "N.kc (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45744)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45678)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "d.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:23441)",
        "u.setChildVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:42286)",
        "c.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:54610)",
        "s.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:61969)",
        "O.Ub (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:110138)",
        "O.setPartHidden (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:114404)",
        "ee.run (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1660:59658)",
        "handler (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:671:18827)",
        "g.invokeFunction (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:638:326)",
        "k.n (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12431)",
        "k.executeCommand (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12019)",
        "Object.accept (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:767:8456)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:647:4013)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "u.Pb (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58913)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58487)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:4714)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "c.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27677)",
        "c.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27539)",
        "J.setSelection (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:8755)",
        "j.u (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:35610)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:54171)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "HTMLDivElement.C (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:8952)"
      ],
      "count": 7,
      "originalStack": ["/src/vs/editor/browser/widget/diffEditor/diffEditorDecorations.ts:231:27"],
      "originalName": "e"
    },
    {
      "type": "mouseup",
      "description": "r=>{r.stopPropagation(),r.preventDefault()}",
      "objectId": "-3511702809039278327.4.12110",
      "stack": [
        "listener (file:///home/simon/.cache/repos/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:735:22835)",
        "new o (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22835)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22233",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:14193)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "m.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:13185)",
        "D.setWidth (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:629:87667)",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:30579)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "p (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11170)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34803)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "D.h (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:23173)",
        "D.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:22981)",
        "a.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34895)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:35107)",
        "y.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2148:10477)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23544",
        "b.W (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23663)",
        "b.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23530)",
        "ee.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:31158)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "c.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:49448)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:59584)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:63999)",
        "T.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:32571)",
        "k.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:33816)",
        "N.kc (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45744)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45678)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "d.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:23441)",
        "u.setChildVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:42286)",
        "c.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:54610)",
        "s.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:61969)",
        "O.Ub (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:110138)",
        "O.setPartHidden (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:114404)",
        "ee.run (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1660:59658)",
        "handler (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:671:18827)",
        "g.invokeFunction (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:638:326)",
        "k.n (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12431)",
        "k.executeCommand (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12019)",
        "Object.accept (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:767:8456)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:647:4013)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "u.Pb (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58913)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58487)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:4714)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "c.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27677)",
        "c.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27539)",
        "J.setSelection (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:8755)",
        "j.u (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:35610)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:54171)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "HTMLDivElement.C (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:8952)"
      ],
      "count": 7,
      "originalStack": ["/src/vs/editor/browser/widget/diffEditor/diffEditorDecorations.ts:227:28"],
      "originalName": "e"
    },
    {
      "type": "mousedown",
      "description": "r=>{r.button!==2&&(r.stopPropagation(),r.preventDefault())}",
      "objectId": "-3511702809039278327.4.12108",
      "stack": [
        "listener (file:///home/simon/.cache/repos/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:735:22758)",
        "new o (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22758)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:736:22233",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:14193)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "h.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18543)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "m.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:13185)",
        "D.setWidth (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:629:87667)",
        "g._runFn (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:30579)",
        "g.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15081)",
        "g.endUpdate (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:15420)",
        "i.finish (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11735)",
        "p (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:11170)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34803)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "D.h (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:23173)",
        "D.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:22981)",
        "a.observe (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:616:34895)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:744:35107)",
        "y.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2148:10477)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23544",
        "b.W (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23663)",
        "b.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2146:23530)",
        "ee.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:31158)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "c.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:49448)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:59584)",
        "s.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:63999)",
        "T.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:32571)",
        "k.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:33816)",
        "N.kc (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45744)",
        "N.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2275:45678)",
        "n.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47294)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:47142)",
        "f.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:24081)",
        "u.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:40645)",
        "d.layout (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:18445)",
        "n.U (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:30758)",
        "n.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:23441)",
        "u.setChildVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:42286)",
        "c.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:54610)",
        "s.setViewVisible (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:61969)",
        "O.Ub (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:110138)",
        "O.setPartHidden (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2342:114404)",
        "ee.run (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1660:59658)",
        "handler (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:671:18827)",
        "g.invokeFunction (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:638:326)",
        "k.n (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12431)",
        "k.executeCommand (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:1538:12019)",
        "Object.accept (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:767:8456)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:647:4013)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "u.Pb (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58913)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:719:58487)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.z (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)",
        "vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:4714)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "c.k (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27677)",
        "c.set (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:27539)",
        "J.setSelection (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:227:8755)",
        "j.u (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:194:35610)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:54171)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "o.value (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:85:53809)",
        "u.y (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)",
        "u.fire (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)",
        "HTMLDivElement.C (vscode-linux-x64-1.85.0/resources/app/out/vs/workbench/workbench.desktop.main.js:87:8952)"
      ],
      "count": 7,
      "originalStack": ["/src/vs/editor/browser/widget/diffEditor/diffEditorDecorations.ts:220:30"],
      "originalName": "e"
    }
  ],
  "isLeak": true
}

Automated test script

git clone git@github.com:SimonSiefke/vscode-memory-leak-finder.git &&
cd vscode-memory-leak-finder &&
git checkout v5.32.0 &&
npm ci &&
node packages/cli/bin/test.js --cwd packages/e2e  --check-leaks --measure-after --measure event-listeners-with-stack-traces --runs 7  --only diff-editor.open &&
cat .vscode-memory-leak-finder-results/event-listeners-with-stack-traces/diff-editor.open.json

Potential Cause

The issue is not present in VS Code 1.84.2. It might have be caused by #199761 It seems to be caused by #198557
@SimonSiefke SimonSiefke mentioned this issue Dec 8, 2023
Merged
@bpasero bpasero assigned hediet and unassigned alexdima Dec 8, 2023
@hediet hediet added this to the December / January 2024 milestone Dec 11, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

fix: memory leak in diff editor SimonSiefke/vscode
5 participants
@hediet @alexdima @SimonSiefke @aiday-mar @VSCodeTriageBot