Fix explorer paste

[lramos15]

Fixes #200581

Seems like there was two issues here

1. You cannot write both a resource and text to the clipboard at the same time
2. Paste was being double triggered causing errors. We shouldn't trigger the native paste handler when no native files are present

cc @bpasero Is there anyway to do the first point?

It seems like reading resources returns nothing if I write text after writing a resource. My hope was that I could have both text and resources written and when pasting depending on the context the proper one would be read

vscode/src/vs/workbench/contrib/files/browser/fileActions.ts

Lines 1211 to 1220 in d85df5d

	async function getFilesToPaste(fileList: FileList | undefined, clipboardService: IClipboardService): Promise<readonly URI[]> {
	if (fileList && fileList.length > 0) {
	// with a `fileList` we support natively pasting files from clipboard
	return [...fileList].filter(file => !!file.path && isAbsolute(file.path)).map(file => URI.file(file.path));
	} else {
	// otherwise we fallback to reading resources from our clipboard service
	return resources.distinctParents(await clipboardService.readResources(), resource => resource);
	}
	}

[bpasero]

@lramos15 please sync with @deepak1556 on that question, in the end we delegate directly to Electron APIs for writing:

vscode/src/vs/platform/native/electron-main/nativeHostMainService.ts

Line 623 in 3648016

return clipboard.writeText(text, type);

vscode/src/vs/platform/native/electron-main/nativeHostMainService.ts

Line 635 in 3648016

return clipboard.writeBuffer(format, Buffer.from(buffer.buffer), type);

[deepak1556]

You cannot write both a resource and text to the clipboard at the same time

This is expected, each clipboard call is synchronous and there is only a single instance of the clipboard to the process. At a time a clipboard can contain multiple representations but not from different calls.

For your scenario, you need https://github.com/electron/electron/blob/main/docs/api/clipboard.md#clipboardwritedata-type but it does not support buffer. We can add support for that in upstream, but you can also switch to using the web clipboard api https://web.dev/articles/async-clipboard