Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension can't be install from market on ./scripts/code-server.sh with nodejs 21 #200934

Closed
kkocdko opened this issue Dec 15, 2023 · 0 comments · Fixed by #200935
Closed

Extension can't be install from market on ./scripts/code-server.sh with nodejs 21 #200934

kkocdko opened this issue Dec 15, 2023 · 0 comments · Fixed by #200935
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders

Comments

@kkocdko
Copy link
Contributor

kkocdko commented Dec 15, 2023

  • VS Code Version: current main branch
  • OS Version: fedora linux 39, kernel 6.6.4-200.fc39.x86_64

Steps to Reproduce:

  1. Enable extension market support for debug, both ./product.json and ./src/vs/platform/product/common/product.ts.
  2. Run ./scripts/code-server.sh to compile, then exit.
  3. Use current nodejs 21 to replace .build/node/v18.17.1/linux-x64/node.
  4. Run ./scripts/code-server.sh, open extension panel, search some name. You can see:

image

This happen only on nodejs 21, not on nodejs 18.

* About running on nodejs 21

The dependencies node-pty and node-spdlog use NAN binding, so them needs recompile, or you can just ignore them.

Or you can use my NAPI port of node-pty. And a faked pure-js spdlog here.

* About this variant of VSCode

The ./scripts/code-server.sh variant runs UI in browser and extension host in nodejs. This variant is used as GitHub Codespace and can be download from https://update.code.visualstudio.com/latest/server-linux-x64-web/insider (or server-win32-x64-web/stable if you want).

* About extension market

VSCode OSS don't have extension market enrtypoint by default, add these content temporarily enabling the market for debugging:

"extensionsGallery": { "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery", "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index", "itemUrl": "https://marketplace.visualstudio.com/items", "controlUrl": "", "recommendationsUrl": "" }

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 16, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Dec 16, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 18, 2023
@sandy081 sandy081 assigned bpasero and unassigned sandy081 Jan 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants