easy no leak test cases #201017
Merged
easy no leak test cases #201017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously approved these changes
Dec 15, 2023
rzhao271
reviewed
Dec 15, 2023
| @@ -36,6 +36,10 @@ suite('NotebookExecutionService', () => { | |||
| let kernelService: INotebookKernelService; | |||
| let disposables: DisposableStore; | |||
|
|
|||
| teardown(() => { | |||
There was a problem hiding this comment.
Instead of disposables as a separate variable, ensureNoDisposablesAreLeakedInTestSuite returns a disposable store to use. Using that function would also render this teardown section unnecessary.
There was a problem hiding this comment.
ensureNoDisposablesAreLeakedInTestSuite isn't being called in this test yet. There's still a leak that @rebornix says he'll look into
rzhao271
reviewed
Dec 15, 2023
| @@ -34,6 +34,10 @@ suite('NotebookExecutionStateService', () => { | |||
| let disposables: DisposableStore; | |||
| let testNotebookModel: NotebookTextModel | undefined; | |||
|
|
|||
| teardown(() => { | |||
There was a problem hiding this comment.
Instead of disposables as a separate variable, ensureNoDisposablesAreLeakedInTestSuite returns a disposable store to use. Using that function would also render this teardown section unnecessary.
rzhao271
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#200091