Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vscode-test-web #201187

Merged
merged 6 commits into from
Dec 19, 2023
Merged

update vscode-test-web #201187

merged 6 commits into from
Dec 19, 2023

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Dec 19, 2023

Updates test-web to fix vulnerability warning coming from @koa/cors

@aeschli aeschli self-assigned this Dec 19, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Dec 19, 2023
benibenj
benibenj previously approved these changes Dec 19, 2023
@aeschli
Copy link
Contributor Author

aeschli commented Dec 19, 2023

Hmm, not that easy, the update of playwrite requires more changes

@aeschli aeschli marked this pull request as draft December 19, 2023 10:50
@aeschli
Copy link
Contributor Author

aeschli commented Dec 19, 2023

Updating to the latest playright causes:

../../node_modules/playwright-core/types/types.d.ts:15912:11 - error TS2339: Property 'asyncDispose' does not exist on type 'SymbolConstructor'.

15912   [Symbol.asyncDispose](): Promise<void>;

microsoft/playwright#28262

Fix is to bump libs to esnext

@aeschli aeschli marked this pull request as ready for review December 19, 2023 14:55
@aeschli aeschli requested a review from bpasero December 19, 2023 14:57
@aeschli aeschli merged commit 56b0088 into main Dec 19, 2023
6 checks passed
@aeschli aeschli deleted the aeschli/annoyed-wasp branch December 19, 2023 15:03
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants