Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start to deprecate boolean for codeActionsOnSave #201808

Merged
merged 2 commits into from
Jan 5, 2024
Merged

start to deprecate boolean for codeActionsOnSave #201808

merged 2 commits into from
Jan 5, 2024

Conversation

justschen
Copy link
Contributor

@justschen justschen commented Jan 4, 2024 •
edited

fixes #200802

  • Still allows booleans to be used, but warning will now be shown that always, never, and explicit are expected.
Screenshot 2024-01-04 at 8 42 21 AM Screenshot 2024-01-04 at 8 42 15 AM

@justschen justschen marked this pull request as ready for review January 4, 2024 23:56
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 4, 2024
@justschen justschen merged commit d2028ff into microsoft:main Jan 5, 2024
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

Assignees

@justschen justschen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings changing on it's own and syncing new value on it's own
3 participants
@justschen @joyceerhl @VSCodeTriageBot