Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial result transfer in quick search #201917

Merged
merged 11 commits into from Jan 16, 2024
Merged

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Jan 5, 2024

Fixes #201916

Instead of importing only the SearchResult, import the whole SearchModel to the panel. This is because there is some logic from within the SearchModel that makes it difficult to import the async search code.

@andreamah andreamah self-assigned this Jan 5, 2024
Base automatically changed from existing-spoonbill to main January 8, 2024 22:25
@andreamah andreamah marked this pull request as ready for review January 16, 2024 22:29
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 16, 2024
bhavyaus
bhavyaus previously approved these changes Jan 16, 2024
@andreamah andreamah merged commit 6d6bb58 into main Jan 16, 2024
6 checks passed
@andreamah andreamah deleted the andreamah/issue201916 branch January 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial search results get transferred from quick search if search is not done
3 participants