Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for quick search individual result #202113

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

andreamah
Copy link
Contributor

No description provided.

@andreamah andreamah self-assigned this Jan 9, 2024
@andreamah andreamah enabled auto-merge (squash) January 9, 2024 23:36
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 9, 2024
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe create a new icon for this? Afaik linkExternal means opening a link outside of the current application

@andreamah
Copy link
Contributor Author

Yes, I was thinking that a new icon would be good, but I couldn't find a codicon that fully fits. I was thinking of temporarily having this icon and asking for a new codicon for this case.

Copy link
Contributor

@justschen justschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamah andreamah merged commit 3822928 into main Jan 11, 2024
7 checks passed
@andreamah andreamah deleted the respective-cougar branch January 11, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants