Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out consecutive separators in custom menus #202388

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Jan 12, 2024

This PR enhances the menu action filtering logic to avoid consecutive or unnecessary separators. Previously, separators could appear consecutively or at the beginning/end of a menu. This update ensures that separators are only present between distinct actions.

@sbatten sbatten self-assigned this Jan 12, 2024
@sbatten sbatten enabled auto-merge (squash) January 12, 2024 23:46
@sbatten sbatten requested a review from sandy081 January 12, 2024 23:46
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 12, 2024
@sbatten sbatten merged commit e09b5f4 into main Jan 15, 2024
7 checks passed
@sbatten sbatten deleted the sbatten/cool-magpie branch January 15, 2024 13:02
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants