Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sticky Scroll Double Header in Settings UI #202506

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix Sticky Scroll Double Header in Settings UI #202506

merged 1 commit into from
Jan 15, 2024
+29 −24

Conversation

benibenj
Copy link
Contributor

Sticky scroll wrongly computed the next sticky node when the sizes of items in the list vary a lot

fix #202090

@benibenj benibenj enabled auto-merge (squash) January 15, 2024 13:58
@benibenj benibenj self-assigned this Jan 15, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 15, 2024
@benibenj benibenj merged commit ee5f222 into main Jan 15, 2024
7 checks passed
@benibenj benibenj deleted the benibenj/increasing-herring branch January 15, 2024 14:13
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double header in settings UI
3 participants
@benibenj @alexr00 @VSCodeTriageBot