announce workspace progress updates to SR users #202621
Conversation
| if (showSpinner) { | ||
| // this step is in progress, communicate it to SR users | ||
| console.log(progress.content.value); | ||
| alert(progress.content.value); |
There was a problem hiding this comment.
This will just read the progress message, right, should there be some context that says this is a progress step?
Also, I'm not sure whether this is the right place to do this. If you scroll up while a workspace message is in progress, then scroll back down, it will read the progress update a second time.
But also, a place that updates the model might not be the right place for it, because maybe you only want this to happen if the chat is actually active on screen.
There was a problem hiding this comment.
This will just read the progress message, right, should there be some context that says this is a progress step?
This is already verbose, we don't need to add more words IMO. I've discussed this with Roberto.
But also, a place that updates the model might not be the right place for it, because maybe you only want this to happen if the chat is actually active on screen.
Do you have a suggestion?
There was a problem hiding this comment.
This is already verbose, we don't need to add more words IMO. I've discussed this with Roberto.
Sure, just remember it's uncontrolled content coming from arbitrary extensions, not just what you see in vscode-copilot.
Do you have a suggestion?
I really don't know, it depends on in what scenario exactly you want to alert. What I mentioned may or may not be an issue.
There was a problem hiding this comment.
In my testing, it works well
fix #199422
I wonder if we should do this more broadly for all progress updates 馃 馃憖. edit: unclear how this would be done ATM, as the
chatServiceImplcannot accessaria.alertand also, there are many instances for which we don't want to announce.