Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak check-requirements for calling ldconfig #202645

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

Leask
Copy link
Contributor

@Leask Leask commented Jan 17, 2024

Sometimes, the target system has ldconfig ready, but you can not assume that /sbin is in $PATH. This may cause the installation of 'ssh remote' to fail.

Fixes microsoft/vscode-remote-release#9405

@Leask
Copy link
Contributor Author

Leask commented Jan 17, 2024

Screenshot 2024-01-17 at 4 00 56 AM

Issue example on latest Debian release.

@aeschli aeschli assigned roblourens and unassigned aeschli Jan 17, 2024
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 added this to the December / January 2024 milestone Jan 18, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) January 18, 2024 18:54
@deepak1556 deepak1556 changed the title tweak check-requirements for calling ldconfig fix: tweak check-requirements for calling ldconfig Jan 18, 2024
auto-merge was automatically disabled January 18, 2024 19:01

Head branch was pushed to by a user without write access

@Leask
Copy link
Contributor Author

Leask commented Jan 18, 2024

@deepak1556 🤝 Done! Thanks for reminding me!

@Leask Leask requested a review from deepak1556 January 18, 2024 19:05
@deepak1556 deepak1556 merged commit 216a8e6 into microsoft:main Jan 18, 2024
6 checks passed
@Leask
Copy link
Contributor Author

Leask commented Jan 19, 2024

Cool! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants