Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support folding notebook cells via sticky scroll #202785

Merged
merged 4 commits into from Jan 22, 2024
Merged

Support folding notebook cells via sticky scroll #202785

merged 4 commits into from Jan 22, 2024

Conversation

Yoyokrazy
Copy link
Contributor

re: #188703

@Yoyokrazy Yoyokrazy self-assigned this Jan 18, 2024
@Yoyokrazy Yoyokrazy changed the title Support folding notebook cells via sticky scroll wip -- Support folding notebook cells via sticky scroll Jan 19, 2024
@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented Jan 19, 2024 •
edited

todo:

  • update testing snapshots (again) to account for changes to header content....

@Yoyokrazy Yoyokrazy marked this pull request as ready for review January 22, 2024 18:51
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 22, 2024
rebornix
rebornix previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in overall, just one nit about how to get the editor contribution instance.

@Yoyokrazy Yoyokrazy enabled auto-merge (squash) January 22, 2024 19:48
@Yoyokrazy Yoyokrazy merged commit de89573 into main Jan 22, 2024
6 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/nb-sticky-folding branch January 22, 2024 20:00
@Yoyokrazy Yoyokrazy changed the title wip -- Support folding notebook cells via sticky scroll Support folding notebook cells via sticky scroll Jan 22, 2024
@Yoyokrazy Yoyokrazy mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yoyokrazy @rebornix @VSCodeTriageBot