Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes alerts are not announced when navigating in the editor with arrow keys #203266

Closed
meganrogge opened this issue Jan 24, 2024 · 11 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jan 24, 2024

@rperez030, when I test the alerts in the editor - specifically for errors and warnings, sometimes the alerts are not read despite the call succeeding.

Note that you'll need to enable the audio cue to get the alert, will be fixed / tracked by #203211.

When this happens, the line content is read instead.

@aiday-mar has reported also having the opposite experience - that is, when navigating an editor with arrow keys, she will hear the alert, for example "error, breakpoint" and not the line content.

Have you experienced these issues?

@meganrogge meganrogge self-assigned this Jan 24, 2024
@meganrogge meganrogge added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach labels Jan 24, 2024
@meganrogge meganrogge added this to the February 2024 milestone Jan 24, 2024
@meganrogge
Copy link
Contributor Author

I'm wondering if this is not an issue because you are using a braille device.

@rperez030
Copy link
Contributor

It is really an issue in macOS. The reason is likely because alerts cause voiceover to remove the content of the speaking queue as a way to give alerts the highest priority. These should probably be status messages instead of alerts. This shouldn't hit production as it is right now.

@meganrogge
Copy link
Contributor Author

Makes sense, thanks. I will go with status instead.

@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jan 24, 2024
@meganrogge meganrogge changed the title Sometimes alerts are not when navigating in the editor with arrow keys Sometimes alerts are not announced when navigating in the editor with arrow keys Jan 24, 2024
@rperez030
Copy link
Contributor

I'll test as soon as it gets merged.

@meganrogge
Copy link
Contributor Author

meganrogge commented Jan 24, 2024

I am testing and see the status message is similarly not announced after the first call (despite debugging showing that the status call does happen). It's still a better solution because we know it won't override the actual line content.

I recall status often doesn't work on macOS in other contexts too.

@meganrogge
Copy link
Contributor Author

separating the issues #203113

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 24, 2024
@meganrogge meganrogge reopened this Jan 24, 2024
@meganrogge meganrogge removed the unreleased Patch has not yet been released in VS Code Insiders label Jan 24, 2024
@meganrogge
Copy link
Contributor Author

it looks like we might need to do something hacky like this https://stackoverflow.com/questions/58734798/aria-live-region-is-not-reading-out-updates-when-an-element-is-removed-on-chrome

@isidorn, did you encounter similar issues and did you consider doing this?

@rperez030
Copy link
Contributor

I am testing and see the status message is similarly not announced after the first call (despite debugging showing that the status call does happen). >

That is interesting. To me it is reading consistently with the audio cue, just overriding the readout of the actual content due to the way in which alerts are handled. In other words, I hear the audio cue and get the alert right after consistently. I'm running macOS sonoma.

@meganrogge
Copy link
Contributor Author

@rperez030, that's great insight. Perhaps this is once again just an issue with my VoiceOver configuration then. Could you pls test in insider's tomorrow, where the status will occur instead of alert?

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2024

@meganrogge I was not encountering issues like this in the past, so I do not have much good context. Sorry

@meganrogge
Copy link
Contributor Author

Closing as an issue with my setup until I'm told otherwise via @rperez030

@meganrogge meganrogge removed the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

5 participants