Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM: View Commit action causes the SCM view to show progress #203307

Closed
joaomoreno opened this issue Jan 24, 2024 · 0 comments 路 Fixed by #205012
Closed

SCM: View Commit action causes the SCM view to show progress #203307

joaomoreno opened this issue Jan 24, 2024 · 0 comments 路 Fixed by #205012
Assignees
@lszomoru
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone
February 2024

Comments

@joaomoreno
Copy link
Member

Testing #203075

  1. Click the View Commit action on a commit in incoming/outgoing.

馃悰 Notice the SCM view shows progress. If there's any progress at all to show, it should be in the multi-file diff editor that opens, not SCM.

馃悰 This is very noticeable in empty commits, where clicking the action does nothing other than showing a progress bar. Related to #203306

Screen.Recording.2024-01-24.at.11.09.10.mov
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Jan 24, 2024
@lszomoru lszomoru added this to the February 2024 milestone Jan 24, 2024
@lszomoru lszomoru mentioned this issue Feb 12, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 12, 2024
@sandy081 sandy081 added the verified Verification succeeded label Feb 22, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
February 2024
Development

Successfully merging a pull request may close this issue.

Git - Update showProgress value in DiffOperation microsoft/vscode
4 participants
@joaomoreno @lszomoru @sandy081 @VSCodeTriageBot