Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Sticky Scroll Focus Space Key Issue #203314

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Jan 24, 2024

This PR addresses an issue with the sticky scroll focus where the 'Space' key was not functioning as expected. Changes include ensuring the focus state is updated only when it changes, focusing on the correct element, and updating the keybinding rule id for better clarity.

#202835

@benibenj benibenj enabled auto-merge (squash) January 24, 2024 10:26
@benibenj benibenj self-assigned this Jan 24, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 24, 2024
@benibenj benibenj merged commit c75ad1f into main Jan 24, 2024
7 checks passed
@benibenj benibenj deleted the benibenj/victorious-mosquito branch January 24, 2024 10:41
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants