Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf - registerWorkbenchContribution2 and some adoptions #203802

Merged
merged 13 commits into from Jan 31, 2024

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jan 30, 2024

This adds a new:

registerWorkbenchContribution2<Services extends BrandedService[]>(
  id: string, 
  ctor: IWorkbenchContributionSignature<Services>, 
  instantiation: WorkbenchContributionInstantiation
): void;

getWorkbenchContribution<T extends IWorkbenchContribution>(id: string): T;

with a new WorkbenchContributionInstantiation.Lazy and deprecation of registerWorkbenchContribution.

It follows how editor contributions work and is for #203445

//cc @jrieken

@bpasero bpasero self-assigned this Jan 30, 2024
@bpasero bpasero added this to the February 2024 milestone Jan 30, 2024
@bpasero bpasero marked this pull request as ready for review January 31, 2024 08:20
@bpasero bpasero enabled auto-merge (squash) January 31, 2024 08:20
joaomoreno
joaomoreno previously approved these changes Jan 31, 2024
@bpasero bpasero changed the title perf - first cut workbench contributions 2 perf - registerWorkbenchContribution2 and some adoptions Jan 31, 2024
@bpasero bpasero merged commit 3b5ae15 into main Jan 31, 2024
6 checks passed
@bpasero bpasero deleted the ben/managerial-antlion branch January 31, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants