Adopt localize2 in more spots #204030
Merged
Adopt localize2 in more spots #204030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another pass adopting localize2
Tyriar
previously approved these changes
Feb 1, 2024
bhavyaus
approved these changes
Feb 2, 2024
joaomoreno
added a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit 7923151.
joaomoreno
added a commit
that referenced
this pull request
Feb 2, 2024
| * | ||
| * This lets you explicitly pass in unlocalized strings to places that normally expect localized strings. | ||
| */ | ||
| export function unlocalized2(str: string): ILocalizedString { |
There was a problem hiding this comment.
This change needs to be done in the nls.build file as well. That's likely what caused the build failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another pass adopting localize2