Tomorrow Night Blue theme: keyword color wrong after update to 1.86.0

[qaqz111]

Type: Bug

I use portable mode that place a sub dir named "data" at VSCode dir where code.exe resides.
I do the update action by extracting new version zip file to a new directory and then move the sub dir "data" from old version to new version VSCode dir.

After update to 1.86.0 from 1.85.2, the keyword color of python file was wrong.

I'm using the "Tomorrow Night Blue" theme.
The keywords lost their color which was set to #EBBBFF in TNB theme and presented with pure white (#FFFFFF).

When I move the "data" dir back to old v1.85.2 VSCode dir and launch v1.85.2 of code.exe, the color comes back.

I also tried a clean launch with an empty "data" folder, then change theme and load a python source code file, the problem is still there no matter install python language extension or not.

[qaqz111]

I found this issue maybe referring the same problem #204197

[zackslash]

Another issue referencing this same problem, unfortunately marked as "*as-designed"
#203998

[KeeganEad]

Same for me on TNB theme. You get so used to a theme over years, that changes like these are very jarring.

[KeeganEad]

Based on the thread linked above, I modified my .vscode/settings.json like so to apply #EBBBFF to several text rules.

Depending on your language you might have different scopes. These were for Typescript.

But you can use CMD+SHIFT+P Developer: Inspect Editor Tokens and Scopes to hover over the syntax and find the scope keys to use.

{
  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [
          "keyword.control.import.ts",
          "keyword.control.from.ts",
          "keyword.control.export.ts",
          "storage.type.ts",
          "meta.function.ts"
        ],
        "settings": {
          "foreground": "#EBBBFF",
          "fontStyle": ""
        }
      }
    ]
  }
}

[tehKaiN]

I still think it's a half-measure for the time being and instead should be fixed/tweaked in the upstream theme itself.

Color FFFFFF seems off-place, has bigger contrast than others, and kinda looks like as if file parsing failed. Over the years of using it, I learned to expect FFFFFF to occur in this theme solely for representing plaintext files or other non-code file fragments, to the point that recent change has confused me for a second, and I thought that something's wrong with the c/c++ plugin and its syntax parser.

If the old color had to go away for reasons unknown, I'd rather see it replaced with something else than eye-burning white.

[KeeganEad]

I agree. I was just having a lot of trouble getting to work yesterday and this morning until I found a solution. Like ain't nobody got time to be tweaking theme colors right now. But it was just too distracting otherwise.

[zackslash]

Downgrading to v1.85 is also a temporary fix for this (i'm in the same boat, don't have bandwidth right now for the distraction)

[qaqz111]

It looks like the grammar parsing rule has been at least partially changed, but I didn't find any information in 1.86 ReleaseNotes. For python the variables lost their color and presented using #FFFFFF confused that whether there were errors in the code file, which really is a disturb in working.

Also downgraded to v1.85.2 for now, looking forward next update to see if the problem will be settled down or at least an explanation about the rule change, or TNB theme update for 1.86+.

[sethvargo]

Asking theme maintainers to update (many of which are archived and unmaintained) without any warning or guidance seems like a regression.

[aeschli]

This was caused by https://github.com/microsoft/vscode/pull/200043/files#diff-feb7ff0a1e168824a90fd0d2f324602089bf3f6d84013c66880673952b5d306f

Fix is on the way...

[levrik]

Add the following to your settings.json to fix it while we wait for a release:

// Temporary workaround for https://github.com/microsoft/vscode/issues/204223
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": "keyword, storage, storage.type, entity.name.tag.css, entity.name.tag.less",
      "settings": {
        "foreground": "#EBBBFF"
      }
    }
  ]
}