Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: tree/list navigation commands #20440

Closed
3 tasks done
bpasero opened this issue Feb 10, 2017 · 0 comments
Closed
3 tasks done

Test: tree/list navigation commands #20440

bpasero opened this issue Feb 10, 2017 · 0 comments
Labels
testplan-item verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 10, 2017

Refs: #11517

We introduced new commands (see below) to make working with trees and lists more configurable for keyboard centric users.

  • verify for all adopters (see below) that the keybindings are working and you can also change them (e.g. take the example of a VIM user that wants to use j, k, l, i for navigation in the tree
  • verify you are not getting into a state where keys suddenly do not work anymore even though the tree/list has focus (interesting corner cases: rename box in files explorer)

Here is a list of new commands that will work in every tree and list (unless specifically overridden, for example the files explorer on macOS does not open on Enter, but rather goes into rename mode. instead, Cmd+Enter will open from the explorer):

Command Keybinding
list.focusUp kbstyle(Up Arrow) (additionally on macOS: kbstyle(Ctrl+P))
list.focusDown kbstyle(Down Arrow) (additionally on macOS: kbstyle(Ctrl+N))
list.focusFirst kbstyle(Home)
list.focusLast kbstyle(End)
list.focusPageDown kbstyle(PageDown)
list.focusPageUp kbstyle(PageUp)
list.collapse kbstyle(Left Arrow) (additionally on macOS: kbstyle(Cmd+Up Arrow))
list.expand kbstyle(Right Arrow)
list.clear kbstyle(Escape)
list.select kbstyle(Enter) (additionally on macOS: kbstyle(Cmd+Enter))
list.toggleExpand kbstyle(Space)

Adopters:

  • Files Explorer
  • Opened Editors
  • SCM Viewlet
  • Problems
  • Quick open (use tab to jump into tree)
  • Search (pay attention that you still see search results opening while you navigate through results)
  • Extensions List
  • Extension Dependencies (e.g. try with "Azure Pack")
  • Debug Hover (click into it to give focus)
  • Debug Variables View
  • Debug Watch Expressions
  • Debug Call Stack
  • Debug Breakpoints
  • Debug Repl (click into to give focus)
@bpasero bpasero added this to the February 2017 milestone Feb 10, 2017
@isidorn isidorn removed their assignment Feb 22, 2017
@roblourens roblourens removed their assignment Feb 22, 2017
@mjbvz mjbvz removed their assignment Feb 22, 2017
@mjbvz mjbvz added the verified Verification succeeded label Feb 22, 2017
@mjbvz mjbvz closed this as completed Feb 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants