New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental terminal inline chat #204844
Conversation
…' into merogge/chatWidget3
src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts
Outdated
Show resolved
Hide resolved
@jrieken could you give this a once over before we merge? I think it's ready to go into main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS changes look good, left a comment about using the wrong context keys.
Also, I wasn't able to test/run this. No matter the settings and tweak I cannot get the command to show up in F1 and the keybinding also isn't working
precondition: ContextKeyExpr.and( | ||
ContextKeyExpr.has(`config.${TerminalSettingId.ExperimentalInlineChat}`), | ||
ContextKeyExpr.and(TerminalContextKeys.processSupported, TerminalContextKeys.focusInAny), | ||
CTX_INLINE_CHAT_HAS_PROVIDER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - this is the wrong context key. It checks for inline chat providers, not for agents/participants
It's working for me, I have this in my keybindings.json to remove the old ctrl+i behavior: { "key": "ctrl+i", "command": "-github.copilot.terminal.suggestCommand",
"when": "terminalFocus" }, |
Does that confirm that it doesn't work ;-) |
I don't think we can work around it until we switch over the default behavior and remove the keybinding from copilot though. |
No description provided.