Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental terminal inline chat #204844

Merged
merged 147 commits into from Mar 6, 2024
Merged

Experimental terminal inline chat #204844

merged 147 commits into from Mar 6, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 9, 2024

No description provided.

@Tyriar Tyriar added this to the February 2024 milestone Feb 9, 2024
@Tyriar Tyriar marked this pull request as ready for review March 4, 2024 19:50
@Tyriar Tyriar requested a review from jrieken March 4, 2024 19:50
@Tyriar
Copy link
Member Author

Tyriar commented Mar 4, 2024

@jrieken could you give this a once over before we merge? I think it's ready to go into main.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS changes look good, left a comment about using the wrong context keys.

Also, I wasn't able to test/run this. No matter the settings and tweak I cannot get the command to show up in F1 and the keybinding also isn't working

precondition: ContextKeyExpr.and(
ContextKeyExpr.has(`config.${TerminalSettingId.ExperimentalInlineChat}`),
ContextKeyExpr.and(TerminalContextKeys.processSupported, TerminalContextKeys.focusInAny),
CTX_INLINE_CHAT_HAS_PROVIDER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi - this is the wrong context key. It checks for inline chat providers, not for agents/participants

@Tyriar
Copy link
Member Author

Tyriar commented Mar 6, 2024

It's working for me, I have this in my keybindings.json to remove the old ctrl+i behavior:

    { "key": "ctrl+i",                "command": "-github.copilot.terminal.suggestCommand",
                                         "when": "terminalFocus" },

@meganrogge meganrogge merged commit db18d58 into main Mar 6, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/chatWidget3 branch March 6, 2024 15:20
@jrieken
Copy link
Member

jrieken commented Mar 6, 2024

It's working for me, I have this in my keybindings.json to remove the old ctrl+i behavior:

Does that confirm that it doesn't work ;-)

@Tyriar
Copy link
Member Author

Tyriar commented Mar 6, 2024

I don't think we can work around it until we switch over the default behavior and remove the keybinding from copilot though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants