-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run in Section for notebook sticky scroll context menu #205307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Feb 15, 2024
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Show resolved
Hide resolved
rebornix
reviewed
Feb 15, 2024
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Outdated
Show resolved
Hide resolved
@Yoyokrazy do you get a chance to update the PR for further review? |
rebornix
reviewed
Feb 20, 2024
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Outdated
Show resolved
Hide resolved
rebornix
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in overall. We can merge this in debt week once the context menu issue is resolved.
rebornix
reviewed
Feb 26, 2024
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Show resolved
Hide resolved
rebornix
reviewed
Feb 26, 2024
src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
Feb 26, 2024
10 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.