Move off in Webview

[rebornix]

I've been working on refactoring the webview related code by dropping all $window references. This task turned out to be quite complex, as it involves a deep understanding of the system to decide how to correctly associate the code windows.

Here are the steps I've taken so far:

• I've made it a requirement to specify the codeWindow when initializing webviews. This is because the webview needs to be aware of the codeWindow from the start, as it listens to messages and events from both window and document ref
• Consequently, I've updated the WebviewElement to use CodeWindow. ref

Next steps are revising the use of webviews across the workbench. For areas where the codeWindow is clearly identified, like in editors (where we have group.windowId), it's straightforward to proceed:

• Notebook. This is straight foward as when creating a notebook, we already know the containing CodeWindow
• Notebook Diff. Same as it's an Editor so I can reading from group.windowId
• Extension Editor. Same as above.
• CodeInset. CodeInset is always insides a monaco editor, so we use the same CodeWindow containing the editor.
• CustomEditor

For cases where the code window isn't explicitly known, especially for requests initiated from the extension host, I used getActiveWindow, but I'm uncertain about its reliability:

• MainThreadWebviewPanel
• Custom Editor
• Webview Commands
• WebviewInputSerializer Is it advisable to serialize and restore the code window id?

@bpasero @mjbvz

[mjbvz]

Thanks for looking into this! Since the WebviewElement is mounted into the Dom, I wonder if we can use this to get the code window in some cases instead of passing it in

That still leaves the call to parentOriginHash(this.codeWindow.origin, ...) (and maybe others I'm overlooking)

Does the origin change for detached editors? If not, maybe we can just the origin of the main window in this case?

[bpasero]

Cool stuff, one thing that worries me is the serialise/deserialise for webviews, I have asked some questions in the code.

[bpasero]

Pushed some changes, I will make sure that this.group is defined early on, so that we can continue to use it for getting the window.

[bpasero]

🚀