testing: fix proposed obsever API not rebuilding test tree #207206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new prefix tree implementation.
connor4312
force-pushed
the
connor4312/test-observer-results
branch
from
dbd80d8
to
1f23437
Compare
connor4312
commented
Mar 8, 2024
| @@ -296,7 +295,7 @@ export class ExtHostTesting extends Disposable implements ExtHostTestingShape { | |||
| public $publishTestResults(results: ISerializedTestResults[]): void { | |||
| this.results = Object.freeze( | |||
| results | |||
| .map(r => deepFreeze(Convert.TestResults.to(r))) | |||
| .map(Convert.TestResults.to) | |||
There was a problem hiding this comment.
We apparently cannot deep freeze objects with URIs, since it causes some getters that cache stuff internally to error out
rebornix
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new prefix tree implementation.