Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split colors into separate files #207633

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Split colors into separate files #207633

merged 4 commits into from
Mar 14, 2024

Conversation

hbons
Copy link
Member

@hbons hbons commented Mar 13, 2024

This pull request splits the colors into separate files for better organization and maintainability. It also splits the excessively long lines over multiple lines for better readability,

Created a new folder colors in vs/platform/theme/common with the following files:

baseColors.ts
chartsColors.ts
editorColors.ts
inputColors.ts # buttons, fields, checkboxes
listColors.ts # lists, tables, trees
menuColors.ts
minimapColors.ts
miscColors.ts # everything else
quickpickColors.ts
searchColors.ts

@hbons hbons self-assigned this Mar 13, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 13, 2024
@hbons hbons merged commit f8be282 into main Mar 14, 2024
6 checks passed
@hbons hbons deleted the colors-cleanup branch March 14, 2024 08:55
@hbons hbons added the themes Color theme issues label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Color theme issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants