Use ChatWidget and ChatModel for inline chat #207864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use chat widget over renderer-reuse and custom input - allow to configure chat menus/actions - allow to define filter for chat list/tree
- allows request parser to check agent by locations - filter agent suggestions by locations
- filter first request
- add TextEdits to chat model - add IChatTextEdit and IChatUsedSlashCommand to chat progress types - hook up ad-hoc agent to inline chat session (no more custom commands) - add new `State.SHOW_REQUEST` state for when new requests are made
- agent clue makes response objects
- content widget and controller tweaks - wire up follow up commands - disable filter for inline chat widget because its weird - hardcode height
- better filtering, refilter when state changes and caching filter condition
- add support for tree-rendering detected command/agent in a special way - first cut of tree-rendering for text edis
- update new required services for tests and adjust them
…d of `this.inputPart.inputPartHeight`
- enable terminal history with new world - fix (most) command group associations
- remove old input widget
- forward agent location to more places - updated snapshots
rebornix
previously approved these changes
Mar 21, 2024
Tyriar
previously approved these changes
Mar 21, 2024
mjbvz
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the inline chat widget to use the ChatWidget that's already used for panel chat and quick chat. Now, all chat location use the same UI and data model, e.g editor chat and also notebook and terminal inline chat. There is still some debt and adoption work but this is the new foundation.