Adopt InlineChatWidget in notebook and fix UI glitches. #207887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
commented
Mar 15, 2024
| @@ -293,8 +294,9 @@ export class InlineChatWidget { | |||
| const widgetToolbarWidth = getTotalWidth(this._elements.widgetToolbar); | |||
| const innerEditorWidth = widgetDim.width - widgetToolbarWidth; | |||
| const inputDim = new Dimension(innerEditorWidth, this._inputWidget.getPreferredSize().height); | |||
| if (!this._lastDim || !Dimension.equals(this._lastDim, widgetDim)) { | |||
| if (!this._lastDim || !Dimension.equals(this._lastDim, widgetDim) || !this._lastInputDim || !Dimension.equals(this._lastInputDim, inputDim)) { | |||
There was a problem hiding this comment.
When the toolbar updates later than the widget, we didn't get a chance to trigger layout again it seems. Thus I added the cache for the input to ensure that it can get updated correctly. cc @jrieken
anthonykim1
approved these changes
Mar 15, 2024
anthonykim1
approved these changes
Mar 15, 2024
src/vs/workbench/contrib/notebook/browser/controller/chat/notebookChatController.ts
Show resolved
Hide resolved
chen-ky
pushed a commit
to chen-ky/vscode
that referenced
this pull request
Mar 18, 2024
…c-crab Adopt InlineChatWidget in notebook and fix UI glitches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.