Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aux window - make it easier to create status elements in all opened windows #208012

Merged
merged 7 commits into from Mar 19, 2024

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Mar 18, 2024

No description provided.

@bpasero bpasero self-assigned this Mar 18, 2024
@bpasero bpasero requested a review from benibenj March 18, 2024 19:15
@bpasero bpasero added this to the March 2024 milestone Mar 18, 2024
@bpasero
Copy link
Member Author

bpasero commented Mar 18, 2024

@benibenj can you see for your scroll lock feature. I also noticed that you did not localize all strings:

this.screenReaderModeElement.value = this.statusbarService.addEntry({
name: localize('status.editor.screenReaderMode', "Screen Reader Mode"),
text,
ariaLabel: text,
command: 'showEditorScreenReaderNotification',
kind: 'prominent',
showInAllWindows: true
}, 'status.editor.screenReaderMode', StatusbarAlignment.RIGHT, 100.6);

@bpasero bpasero marked this pull request as ready for review March 18, 2024 19:21
@benibenj
Copy link
Contributor

Very nice! Works great

@bpasero bpasero merged commit 7c4c34e into main Mar 19, 2024
6 checks passed
@bpasero bpasero deleted the ben/social-pheasant branch March 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants