Subpath support in Code serve-web for WSS connections

[zuoky]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: latest MR
• OS Version: Kubernetes 1.28, ContainerD 1.7.0

Steps to Reproduce:

code serve-web --host 0.0.0.0 --port 8080 --default-workspace=/home/workspace --default-folder=/home/workspace --disable-telemetry --server-base-path=/ides/foo --without-connection-token

Related issue: Github Issue
Metion: @connor4312

[VSCodeTriageBot]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[zuoky]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

These are latest code as of 20240321, no version tagged yet.

[aeschli]

Fixed by #207932

[okalldal]

@aeschli this issue seems like it is still present. It is possible to start the server and get server-base-path to work for most network communications, but when accessing the server from the browser you get a popup indicating websocket connections fail. When inspecting network traffic, websocket connections indeed tries to initialize connections without the specified base path.

It looks like @zuoky also can confirm this issue since he asserts that he is using the latest code as of 20240321 (three days after #207932 was merged). @zuoky are you able to confirm that this is still not working from your side?

[aeschli]

Here's what I tested and works for me: (latest insiders build)

• start code-insiders serve-web --host 0.0.0.0 --port 8080 --server-base-path=/ides/foo
• open a local browser on http://localhost:8080/ides/foo.
• open a browser on a machine in the same network: http://192.168.1.77:8080/ides/foo

If you have any other configuration (e.g. a proxy server) you will have to investigate if the issue is there. If there's anything VS Code needs to add to make additional setups working, please let us know. The best is to provide a fix through a PR.

If the steps above don't work for you, please create a new issue and describe what's not working.

[zuoky]

We have tried these and can reproduce this issue:

1 Configure a server base path and start vscode.
2 Through nginx proxy, for example, when requesting https://foo.example.com/ide/foo, a wss error occurs. By checking the browser console, you can see the wss error, and the request address is wss://foo.example.com/oss-xxxx, which does not include the server base path URI path.
3 An example configuration for nginx proxy is as follows:

upstrem vscode {
  server  [192.168.0.100:8888](http://192.168.0.100:8888/);
}
server {
   servername [foo.example.com](http://foo.example.com/);
   location / {
            proxy_pass http://vscode/;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection $connection_upgrade;
      }
}

[okalldal]

@aeschli Could the reason why it works for you be that since you are not behind a proxy, the WSS request will succeed even without the serverBasePath added (i.e. neither the server nor client expects the WSS requests to have the base path added).

In my and @zuoky :s case only requests with the proper prefix will be forwarded to the server and thus the WSS connections will be refused.

[aeschli]

Again, please file a separate issue so we can investigate in there.