Notebook outline view: Symbols are often incomplete

[aeschli]

Testing #208546

Version: 1.88.0-insider
Commit: b0d975f
Date: 2024-03-25T05:51:49.226Z
Electron: 28.2.6
ElectronBuildId: 27476517
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 5.14.0-1048-oem

• Create a notebook with a JavaScript code block below.
• In the outline enable Code Cell Symbols
• you can see temp1232, temp33, add and sub
• change the name of a temp. Outline does not update
• close the notebook and reopen it. Now it shows
• change the type of the cell from JavaScript to Python. Also no change.

// fn cell
const temp1232 = "hello world"
const temp33 = "hello world"

console.log(temp);

function add(a, b) {
    return a + b;
}

console.log(add(1, 2));1

function sub(a, b) {
    return a - b;
}

[Tyriar]

I also saw this:

[Tyriar]

It eventually updated 🤷

[Yoyokrazy]

I believe this is a consequence of symbol fetching being an asynchronous operation. The goal was to avoid symbol fetching blocking the outline view updating, but currently there are some issues with the outline view not updating as symbols are finished being gathered. There will be a bit more work here, likely involving a different event flow to the outline recompute.

[Yoyokrazy]

Update after debt investigations:

• this is due to the outlineEntryFactory having its own cache for symbols, and when we check for updates to the outline, the new symbols are not present in the outlineView model cache and therefore not being included in the recomputed NotebookCellOutline. Once the there is a single provider, single outlineModel, and then a single outlineViewModel, they will share the same cache and therefore will be recomputed and shown to the user in real time.
• Solution to this will be included in the refactor work in Refactor: share outline between nb sticky scroll and outline #200873, so going to avoid patching just this case in particular rn. The bigger refactor is in progress, but will finalize during the next complete debt week (beginning of May)