Shell integration docs and readonly #208796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing feedback in #208257
meganrogge
approved these changes
Mar 26, 2024
karrtikr
reviewed
Mar 26, 2024
| */ | ||
| shellIntegration: TerminalShellIntegration | undefined; |
There was a problem hiding this comment.
Question: Does this API also take into account when shell integration is manually installed? Meaning, if automatic shell integration is failing, and manual installation works, does it return the shell integration object?
There was a problem hiding this comment.
@karrtikr yes it does, the auto injection stuff is finished when the process launches; this is set as soon as a command sequence comes in I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing feedback in #208257