New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comments accessible view #209977
add comments accessible view #209977
Conversation
src/vs/workbench/contrib/accessibility/browser/accessibleViewContributions.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, but it looks reasonable. I left a few comments so I disabled auto-merge.
It looks like this is the established pattern for adding accessible views, but right now the accessible view contribution needs to know everything about every accessible view. It might be cleaner to instead have each component contribute an accessible view to prevent accessible view code from needing to know about the whole world.
src/vs/workbench/contrib/accessibility/browser/accessibleViewContributions.ts
Show resolved
Hide resolved
I was thinking the same thing while implementing this. I've created an issue for debt week, thanks. I will address your other comments in a follow up PR. |
fixes #203928