Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments accessible view #209977

Merged
merged 14 commits into from Apr 15, 2024
Merged

add comments accessible view #209977

merged 14 commits into from Apr 15, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Apr 9, 2024

fixes #203928

Screenshot 2024-04-12 at 1 14 45 PM

@meganrogge meganrogge self-assigned this Apr 9, 2024
@meganrogge meganrogge marked this pull request as draft April 9, 2024 18:10
@meganrogge meganrogge added this to the April 2024 milestone Apr 9, 2024
@meganrogge meganrogge changed the title comments accessible view add comments accessible view Apr 9, 2024
@meganrogge meganrogge marked this pull request as ready for review April 10, 2024 19:21
@meganrogge meganrogge requested a review from alexr00 April 10, 2024 19:21
@meganrogge meganrogge enabled auto-merge (squash) April 10, 2024 21:26
@meganrogge meganrogge enabled auto-merge (squash) April 10, 2024 21:27
@meganrogge meganrogge enabled auto-merge (squash) April 13, 2024 01:38
@alexr00 alexr00 disabled auto-merge April 15, 2024 13:19
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it looks reasonable. I left a few comments so I disabled auto-merge.

It looks like this is the established pattern for adding accessible views, but right now the accessible view contribution needs to know everything about every accessible view. It might be cleaner to instead have each component contribute an accessible view to prevent accessible view code from needing to know about the whole world.

@meganrogge
Copy link
Contributor Author

I haven't tested this, but it looks reasonable. I left a few comments so I disabled auto-merge.

It looks like this is the established pattern for adding accessible views, but right now the accessible view contribution needs to know everything about every accessible view. It might be cleaner to instead have each component contribute an accessible view to prevent accessible view code from needing to know about the whole world.

I was thinking the same thing while implementing this. I've created an issue for debt week, thanks.

I will address your other comments in a follow up PR.

@meganrogge meganrogge merged commit af930dc into main Apr 15, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/comments-view branch April 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Support Accessible View (Alt+F2) in the GitHub comment thread item.
2 participants