Notebook: status bar is not floating window aware #210383
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
notebook
workbench-auxwindow
Issues related to use of auxiliary ("floating") windows.
Milestone
This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window:
We have had a similar issue with the text editor status bar and solved it by instantiating it per-window:
vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts
Lines 895 to 904 in b41db61
I think a similar approach would work for notebooks too.
The key for this to work is that you get a scoped
IEditorService
in theonDidCreateAuxiliaryEditorPart
that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar:vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts
Line 897 in b41db61
Let me know if you have questions, but I think its easy to copy what we do for editor status here.
The text was updated successfully, but these errors were encountered: