Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option for editor.autoClosingBrackets to not auto-close if there's a syntax error in the file #210437

Open
DetachHead opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
polish Cleanup and polish issue

Comments

@DetachHead
Copy link

DetachHead commented Apr 16, 2024

a very common cause of syntax errors are open brackets without a closing bracket, or vice versa:

const foo = }

attempting to fix this is always extremely annoying because it inserts another closing bracket, preventing the syntax error from being fixed:

Recording.2024-04-16.153253.mp4

setting it to beforeWhitespace makes it a bit less annoying (at least it used to, see #210436), but it can still sometimes insert closing brackets in cases where it causes a syntax error.

i think an option to only insert an auto-closing bracket when there are no syntax errors in the file would be a massive improvement

@aeschli aeschli assigned hediet and unassigned aeschli Apr 22, 2024
@hediet hediet assigned aiday-mar and unassigned hediet Apr 23, 2024
@aiday-mar aiday-mar added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue and removed bug Issue identified by VS Code Team member as probable bug labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

5 participants