Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitted Terminal border color and thickness customization #210579

Open
MetaMmodern opened this issue Apr 17, 2024 · 2 comments
Open

Splitted Terminal border color and thickness customization #210579

MetaMmodern opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Milestone

Comments

@MetaMmodern
Copy link

MetaMmodern commented Apr 17, 2024

Hi! I'm using splitted terminal constantly, since it's very nice and convinient. However, when using it on Windows I've noticed one thing that makes me want to use Windows Terminal app more that the vscode terminal: it's the border, separating two terminals.

With my default theme here's how it looks like:
image

You can see that although it's quite obvious where one terminal window ends and where the next one begins, but if you're doing a quick lookup it's a but fuzzy, it's not quite solid.

VSCode allows to customize border color, but honestly it doesn't look that nice because it forced you to customize all panel borders. Also I noticed there's an editorGroup.border, which let's customize the editor border. Here's how it looks like with both properties engaged:

image

You can see it added green borders where I didn't want to have them.

And I've added the red editor border just to demonstrate what I wanted to have instead. It would be nice to have something like

terminalGroup.border

And just for comparison here's how it looks like in Windows Terminal
image

And another thing related to this is the border thickness. You can see that Windows Terminal has around 2-3px of borderSize. It makes it look much more solid. You can see how weak the thin vscode line looks like. I'd like to have an ability to declare in settings what the border size is. Even if you hardcode it to some kind of mapping like "thin"/"thick", that would be better already that what we currently have.

Thanks in advance!

@ArturoDent
Copy link

"terminal.border": "#ff0000",

is slightly better - there is no border top colored.

@MetaMmodern
Copy link
Author

@ArturoDent yep, definetely. Thanks, I'll cope with that one for now:)

@lszomoru lszomoru assigned Tyriar and meganrogge and unassigned lszomoru Apr 21, 2024
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Apr 21, 2024
@Tyriar Tyriar added this to the Backlog milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

6 participants