Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion/Bug in Explorer navigation: Parent Directory is considered selected by default when (command +) selecting files or subdirectories. #210608

Closed
AbhinavRao23 opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@AbhinavRao23
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.88.0
  • OS Version: macOS 13.4.1

Summary:
When you click on a directory in explorer and ravel it, to subsequently select multiple file(s) or subdirectory(s) using command + click, the original parent is by default considered a part of the selection unless explicitly dead-clicked. This in a hurry, leads to a common issue of deleting entire parent directory if the caution message is not read (which is not uncommon to be blindly dismissed) or if the caution message is turned off. In any case, it is a design error for the original parent directory to be selected as a part of the serial selection.

Steps to Reproduce:
(Let's say I have a directory called Parent with files called file1, file2, file3, I want to delete file1 and file2)

  1. Click to ravel Parent directory in explorer.
  2. 'command' + click on file1 and file2.
  3. 'right click' and select 'delete'.

In the picture below,

  1. I click on 'results'
  2. Then 'command + click' on the two 'ExpCheck-..' files.
  3. If I delete the two files, the parent 'results' will be also deleted since it was considered a part of the selection.
  4. Caution message may come up if you havent disabled it.

Screenshot 2024-04-17 at 7 28 53 PM

Solution: 'Click to ravel' should not be added in the selection stack.

@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.88.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@lramos15 lramos15 added the *as-designed Described behavior is as designed label Apr 29, 2024
@lramos15
Copy link
Member

macOS native finder does the same

@VSCodeTriageBot
Copy link
Collaborator

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants