Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs from ChatResponseTextEditParts should be inline when narrow #210793

Open
connor4312 opened this issue Apr 19, 2024 · 4 comments
Open

Diffs from ChatResponseTextEditParts should be inline when narrow #210793

connor4312 opened this issue Apr 19, 2024 · 4 comments
Assignees
Labels
chat feature-request Request for new features or functionality polish Cleanup and polish issue
Milestone

Comments

@connor4312
Copy link
Member

Adopting the ChatResponseTextEditPart, it's very nice that it's shown in the diff editor, but it's a bit hard to read due to is narrowness

image

@hediet hediet added this to the April 2024 milestone Apr 23, 2024
@hediet hediet added panel-chat polish Cleanup and polish issue diff-editor Diff editor mode issues labels Apr 23, 2024
@hediet hediet assigned jrieken and unassigned hediet Apr 23, 2024
@hediet
Copy link
Member

hediet commented Apr 23, 2024

Seems to be intentially disabled:

useInlineViewWhenSpaceIsLimited: false,

@hediet hediet removed this from the April 2024 milestone Apr 23, 2024
@hediet hediet removed polish Cleanup and polish issue diff-editor Diff editor mode issues panel-chat labels Apr 23, 2024
@jrieken jrieken added feature-request Request for new features or functionality polish Cleanup and polish issue chat labels Apr 23, 2024
@jrieken
Copy link
Member

jrieken commented Apr 23, 2024

It will almost always be narrow because chat is in the sidebar or inside an editor. We have discussed

  • an explicit toggle
  • some smarts that automatically uses inline when diffs are dominated by insertions and/or removals

@hediet Is the latter something the diff editor could support?

@jrieken jrieken added this to the Backlog milestone Apr 23, 2024
@hediet
Copy link
Member

hediet commented Apr 23, 2024

some smarts that automatically uses inline when diffs are dominated by insertions and/or removals

Yes, the diff editor could support this! I don't think this feature would work very well for changing/writable files, as it might jump.

@jrieken
Copy link
Member

jrieken commented Apr 23, 2024

I don't think this feature would work very well for changing/writable files, as it might jump.

You could do this only on first open/load of a model but not on subsequent changes to the models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat feature-request Request for new features or functionality polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants