Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM view is not helpful when there is no SCM repo #21103

Closed
sandy081 opened this issue Feb 22, 2017 · 6 comments
Closed

SCM view is not helpful when there is no SCM repo #21103

sandy081 opened this issue Feb 22, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues ux User experience issues verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #20999

  • OS Version: Windows

Steps to Reproduce:

  1. Open VS Code on a folder which does not have SCM repo initialized
  2. Open SCM view
  • It is not helpful to figure out that you can initialise the repo from there.
  • Top right icon looks like a Git label rather than an action button
  • Commit box and changes take much precedence and misleading
  • It would be useful if we can make Initialise action much prominent (like in old git)

image

@sandy081 sandy081 added the ux User experience issues label Feb 22, 2017
@joaomoreno
Copy link
Member

How about if we put the Git Init action in the ... menu?

@joaomoreno joaomoreno added this to the March 2017 milestone Feb 22, 2017
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 22, 2017
@sandy081
Copy link
Member Author

Probably a different icon to initialise might help. To me, even though I am used to the view with actions on the right.. First impression I got was "Ok, now we are mentioning that, this is a Git SCM using the icon there", But not to initialise. After hovering over it I got to know it is to initialise. But this is my impression. May be others get to it straight.

Is not it possible to show a disable mode for the commit box and not show any changes? Or

How about following flow:

  • Show everything under changes
  • When user tries to commit, initialise the repo and ask for more custom options ?

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2017

A button like in the explorer to initialize a repo might be good too, that way it would be a more explicit action since it's creating a .git/ directory:

image

@joaomoreno
Copy link
Member

Pushing this out to April.

@joaomoreno joaomoreno modified the milestones: April 2017, March 2017 Mar 30, 2017
@joaomoreno joaomoreno added the git GIT issues label Apr 26, 2017
@joaomoreno
Copy link
Member

Improved a bit:

image

There are more ideas coming up.

@michelkaporin
Copy link
Contributor

michelkaporin commented Apr 28, 2017

I like the proposal by @Tyriar.

Also the current 'Initialize Repository' button does not look like a button, rather as a non-clickable text, until you hover over it.
As for now, it's enough as a bug fix, putting verified.

@michelkaporin michelkaporin added the verified Verification succeeded label Apr 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants